Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Add peaks generation to reconst workflows #3169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Apr 4, 2024

All in the title.

Many of our reconstruction workflows were not saving the peaks which could be problematic if the user want to generate a tractogram. This PR fix mainly this issue.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 82.39%. Comparing base (cdaf8a9) to head (5f6f801).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
- Coverage   82.40%   82.39%   -0.02%     
==========================================
  Files         151      151              
  Lines       21316    21297      -19     
  Branches     3419     3414       -5     
==========================================
- Hits        17566    17547      -19     
- Misses       2908     2910       +2     
+ Partials      842      840       -2     
Files Coverage Δ
dipy/workflows/reconst.py 76.50% <76.59%> (-0.39%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant