WIP: QTI Simulation Tutorial

[shilpiprd]

This is work in progress, it contains the qti simulation tutorial. Also, I haven't added the signal image yet in the file, I'll add it later after everything else is reviewed.

[codecov]

Codecov Report

Merging #2830 (0002367) into master (3e9caf8) will increase coverage by 0.13%.
Report is 303 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
+ Coverage   81.47%   81.61%   +0.13%     
==========================================
  Files         144      146       +2     
  Lines       20054    20363     +309     
  Branches     3192     3224      +32     
==========================================
+ Hits        16339    16619     +280     
- Misses       2906     2924      +18     
- Partials      809      820      +11     

see 48 files with indirect coverage changes

[RafaelNH]

Hi @shilpiprd! Thanks for your PR. I may have some follow up suggestions after this first round of comments. Please let me know is something is not clear.

[shilpiprd]

Hey Rafael, so I've made some basic changes, let me know what more needs to be done.
Thanks,

[skoudoro]

is it still a work in progess tutorial @shilpiprd and @RafaelNH ?

[shilpiprd]

I think it's done code wise, but it could maybe use a little improvement in the docstring ?

[skoudoro]

I think it's done code wise, but it could maybe use a little improvement in the docstring ?

I agree, do you have a timeline to add a bit of the docstring. it would be great to merge this PR before the release on October. @RafaelNH , can you help ?

[pep8speaks]

Hello @shilpiprd, Thank you for updating !

• In the file doc/examples/qti_simulation_tutorial.py:

Line 24:81: E501 line too long (114 > 80 characters)
Line 56:81: E501 line too long (107 > 80 characters)

[shilpiprd]

I've made some basic changes, but I still think Rafael needs to provide some review on this.

[skoudoro]

Hi @RafaelNH,

So, What is the conclusion concerning this PR? Will you find time to address the issue this week or it should go for the next release in December ?

Thank you for your feedback.

[skoudoro]

Hi @RafaelNH,

Do you have an update on this?

[skoudoro]

Hi @RafaelNH,

Do you have an update on this?

[skoudoro]

Hi @RafaelNH,

I hope you are doing well. Please, what is the feedback on this?

[RafaelNH]

Hi all! I figured out that QTI is not compatible with single voxel simulations. I have to fix that before progressing with the work on this PR - there is no sense in creating these single voxel simulations if QTI is not compatible with them. I will try to resume the work here as soon as possible, but I am prioritizing other PRs like #3151 and #2826.

[skoudoro]

Thank you for the feedback 👍