check failed mac basicrpc test #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: get rid of gcc on darwin, we should use clang for native darwin builds.
```
cc/import.cpp: In function 'int32_t CheckCODAimport(CTransaction, CTransaction, std::vector<CTxOut>, std::string, std::string)':
cc/import.cpp:260:12: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
260 | out[65]='\0';
| ~~~~~~~^~~~~
cc/import.cpp:247:44: note: at offset 65 into destination object 'out' of size 65
247 | cJSON *result,*tmp,*tmp1; char *retstr,out[SHA256_DIGEST_LENGTH*2+1]; int i,n,m;
| ^~~
```
actually this is not needed, and the line out[64]='\0' could be commented,
as sprintf actually writes 3 bytes per call, i.e. for hash[i] = 0xca, it
will actually write the following sequence of bytes 'c', 'a', 0x00. So,
end of string will be always with end NUL byte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.