Fixed: translations not saved when object not dirty. (laravel core wa…

…s updated)
dimsav · Jun 20, 2014 · ace069b · ace069b
1 parent 6f4f544
commit ace069b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/Translatable/Translatable.php b/Translatable/Translatable.php
@@ -105,11 +105,18 @@ public function setAttribute($key, $value)
 
     public function save(array $options = array())
     {
-        if (parent::save($options))
+        if (count($this->getDirty()) > 0)
+        {
+            if (parent::save($options))
+            {
+                return $this->saveTranslations();
+            }
+            return false;
+        }
+        else
         {
             return $this->saveTranslations();
         }
-        return false;
     }
 
     public function fill(array $attributes)

diff --git a/tests/TestCoreModelExtension.php b/tests/TestCoreModelExtension.php
@@ -38,7 +38,7 @@ public function it_throws_query_exception_if_saving_and_name_is_null()
     /**
      * @test
      */
-    public function it_returns_false_if_save_was_not_successful()
+    public function it_returns_false_if_parent_save_was_not_successful()
     {
         $that = $this;
         $event = App::make('events');
@@ -47,6 +47,7 @@ public function it_returns_false_if_save_was_not_successful()
             });
 
         $country = Country::find(1);
+        $country->iso = 'make_model_dirty';
         $country->name = 'abc';
         $this->assertFalse($country->save());
     }