Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension of files referenced by header #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

awesomebytes
Copy link

I... don't really know how this was working for anyone?

Or maybe it's a weird behaviour of my system and .h and .hpp should be detected anyways?

Oh well, this fixed it for me. It corrects the error (for google searches):

Errors     << image_transport_py:make /home/sam/workspaces/roscpp_py_ws/logs/image_transport_py/build.make.061.log
In file included from /home/sam/workspaces/roscpp_py_ws/src/image_transport_py/src/image_transport_py.cpp:7:0:
/home/sam/workspaces/roscpp_py_ws/src/pyrosmsg/include/pyrosmsg/pyrosmsg.h:4:10: fatal error: pyrosmsg/converters.h: No such file or directory
 #include "pyrosmsg/converters.h"

It took me embarrassingly long to figure it out.

pyrosmsg.h was pointing to files with the wrong extension
Fixes:
```Errors     << pyrosmsg:check /home/sam/workspaces/roscpp_py_ws/logs/pyrosmsg/build.check.071.log
CMake Error at /opt/ros/melodic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
  Could not find a package configuration file provided by "pybind11" with any
  of the following names:

    pybind11Config.cmake
    pybind11-config.cmake

  Add the installation prefix of "pybind11" to CMAKE_PREFIX_PATH or set
  "pybind11_DIR" to a directory containing one of the above files.  If
  "pybind11" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:6 (find_package)
```
@awesomebytes
Copy link
Author

I also remembered another error that was quickly fixed:

Errors     << pyrosmsg:check /home/sam/workspaces/roscpp_py_ws/logs/pyrosmsg/build.check.071.log
CMake Error at /opt/ros/melodic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
  Could not find a package configuration file provided by "pybind11" with any
  of the following names:

    pybind11Config.cmake
    pybind11-config.cmake

  Add the installation prefix of "pybind11" to CMAKE_PREFIX_PATH or set
  "pybind11_DIR" to a directory containing one of the above files.  If
  "pybind11" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:6 (find_package)

(Added to this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant