Linear Repeat Structure Support for Formplayer

[shubham1g5]

Product Description

JIra

Adds support for using both counted and non counted repeat groups in a single form on Web Apps.

Technical Summary

Spec

Safety Assurance

Safety story

• Will go through QA once supporting changes are done on Web Apps
• Unit tests are added to verify non counted repeat groups work correctly, there should not be any other impact of removing the non linear repeat strucuture

Automated test coverage

• Added in PR

QA Plan

Notes here

QA ticket tbd

Special deploy instructions

Should only be deployed after the corresponding Web Apps changes are deployed

Rollback instructions

• This PR can be reverted after deploy with no further considerations.

Review

• The set of people pinged as reviewers is appropriate for the level of risk of the change.

cross_request: dimagi/commcare-core#1408

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (77abcf0) to head (0428c6d).
Report is 2 commits behind head on master.

❗ Current head 0428c6d differs from pull request most recent head 0166a04. Consider uploading reports for the commit 0166a04 to get more accurate results

Files	Patch %	Lines
...org/commcare/formplayer/api/json/PromptToJson.java	81.81%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1567      +/-   ##
============================================
- Coverage     70.51%   69.74%   -0.78%     
+ Complexity     2025     2005      -20     
============================================
  Files           252      252              
  Lines          7829     7839      +10     
  Branches        721      714       -7     
============================================
- Hits           5521     5467      -54     
- Misses         2037     2101      +64     
  Partials        271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[snopoke]

I'm not able to review this at the moment. I also don't have a good grasp of linear vs non linear repeat structures.