Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds datadog tags to traces for restore and app installs #1547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Feb 26, 2024

Product Description

No visual change.

Technical Summary

Adds a span tags attempt_restore and new_install to Datadog. These processes can lead to slow response times so the tags are added so those requests can be filtered and analyzed independently.

Screen Shot 2024-02-26 at 1 22 40 PM

Related #1526 which added this metadata to the response and PR which adds these tags to metrics.
USH-4069

Safety Assurance

Safety story

Tested on staging. No change to product behavior.

Automated test coverage

QA Plan

no QA

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@Jtang-1 Jtang-1 marked this pull request as ready for review February 26, 2024 21:26
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.08%. Comparing base (63e4d12) to head (b816b7b).

Files Patch % Lines
...e/formplayer/services/ResponseMetaDataTracker.java 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1547      +/-   ##
============================================
- Coverage     70.13%   70.08%   -0.06%     
  Complexity     1987     1987              
============================================
  Files           252      252              
  Lines          7736     7744       +8     
  Branches        695      697       +2     
============================================
+ Hits           5426     5427       +1     
- Misses         2045     2051       +6     
- Partials        265      266       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +30 to +31
final Span span = GlobalTracer.get().activeSpan();
if (span != null && (span instanceof MutableSpan)) {
Copy link
Contributor

@nospame nospame Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this want to use a check similar to the one added here dimagi/commcare-core@fcdceca ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants