Don't use gevent since order isn't guaranteed #34605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gherceg
force-pushed
the
gh/es/fix-bug-with-reindex-output
branch
from
17d9342
to
1382fd9
Compare
Is it true? I thought the results will be placed in array in the order they have been called, the results may come before and after but when you access them in array the position would be deterministic 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
It doesn't seem necessary to use gevent here anyway, and based on the output of this command, it looks like the order of results returned isn't guaranteed (which makes sense).
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
No QA
Rollback instructions
Labels & Review