Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert purge ids change #34604

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Revert purge ids change #34604

wants to merge 3 commits into from

Conversation

gherceg
Copy link
Contributor

@gherceg gherceg commented May 10, 2024 •
edited

Product Description

Technical Summary

Apparently we still need to set this flag when reindexing based on the most recent attempt to reindex case search.

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@gherceg gherceg requested a review from calellowitz May 10, 2024 19:34
@gherceg gherceg added the Open for review: do not merge A work in progress label May 10, 2024
@gherceg gherceg changed the title [Temporary] Revert purge ids change Revert purge ids change May 10, 2024
@gherceg
Make changes to script to be compatible with ES 5
2a6bd84 
- support painless
- append scripts to work with copy_doc_ids
@gherceg gherceg force-pushed the gh/es/tmp-revert-purge-ids branch from 35dd985 to 2a6bd84 Compare May 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esoergel esoergel Awaiting requested review from esoergel esoergel is a code owner

@AmitPhulera AmitPhulera Awaiting requested review from AmitPhulera AmitPhulera is a code owner

@calellowitz calellowitz Awaiting requested review from calellowitz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Open for review: do not merge A work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gherceg