Profile Case Search #34603
Open
Profile Case Search #34603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoergel
commented
May 10, 2024
| def get_base_queryset(self): | ||
| def get_base_queryset(self, slug=None): | ||
| # slug is only informational, used for profiling | ||
| CaseSearchES = self.profiler.get_case_search_class(slug) |
There was a problem hiding this comment.
I'm not certain whether this is the best way to override the class, but I do like the idea of using an auto-logging subclass rather than needing to use the profiler to call run. Open to feedback if you can think of a cleaner approach
esoergel
requested review from
orangejenny,
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
This should hopefully make the profiling code a bit less obtrusive It also means the ancestor queries will be profiled now too
To avoid messing up the numbers of the actual query
esoergel
force-pushed
the
es/profile-queries
branch
from
1502eda
to
c93dde8
Compare
MartinRiese
approved these changes
May 21, 2024
|
|
||
| def add_query(self, slug, es_query): |
There was a problem hiding this comment.
Was this function just unused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Make the profiling code a bit less obtrusive
Feature Flag
Safety Assurance
Relying on automated and local tests
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review