Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch missing SQLLocation #34597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Catch missing SQLLocation #34597

wants to merge 1 commit into from

Conversation

kaapstorm
Copy link
Contributor

Technical Summary

Resolves this Sentry error.

This function is used in two places. Both places already check whether it returned None.

(One of those places is the clean() method on a model, and that seems fine. But the other place fetches the latest enabled build for a user based on their location. So this error means that there is a user out there assigned to a location that doesn't exist. I will follow up.)

Safety Assurance

Safety story

Catches an uncaught exception, and returns a valid return value instead.

Automated test coverage

Not covered by automated tests.

QA Plan

QA not planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

Copy link
Contributor

@mkangia mkangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

When I wrote this function 5 years ago, I wasn't able to foresee this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants