Catch exception in case of missing ds table #34595
Open
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkangia
reviewed
May 10, 2024
| try: | ||
| with self.session_context() as session: | ||
| session.execute(delete) | ||
| except ProgrammingError: |
There was a problem hiding this comment.
Thanks for the revisit to the approach. Since ProgrammingError could come for different reasons, can we combine your original solution as
except ProgrammingError as e:
if not self.table_exists:
return
else:
raise e
There was a problem hiding this comment.
@mkangia Cool, let me make some updates
mkangia
reviewed
May 22, 2024
| if not self.table_exists: | ||
| return | ||
| else: | ||
| raise e |
There was a problem hiding this comment.
nit:
Just noting that the else here is redundant. And a comment could be useful.
if not self.table_exists: # ignore error if table is missing
return
raise e
mkangia
approved these changes
May 22, 2024
Not a bad idea. |
mkangia
reviewed
May 23, 2024
| self.adapter = IndicatorSqlAdapter(config) | ||
|
|
||
| def tearDown(self): | ||
| self.adapter.drop_table() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces this PR, but with the difference being that we're catching the exception instead of checking whether or not the table exists.
Technical Summary
Ticket
An error was picked up by sentry in which a case made changes to a UCR that does not exist. This PR is simply to catch the error when the table does not exist and return, since no further work is necessary.
That said, I don't think this addresses the real problem, i.e. why the case change is propagated for this config which is supposedly deleted. This issue is to be investigated further, but this PR change will at least silence the error.
Feature Flag
UCRs
Safety Assurance
Safety story
--
Automated test coverage
No tests, don't think it's necessary for such a simple change.
QA Plan
No QA
Rollback instructions
Labels & Review