Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID to HTML Elements in the Geospatial Feature #34573

Merged
merged 2 commits into from May 22, 2024

Conversation

zandre-eng
Copy link
Contributor

Technical Summary

Link to ticket here.

Very small PR that only adds an id attribute to a few HTML elements of the Geospatial feature. This is being done so that these elements can be uniquely identified and tracked in product analytics tooling such as Kissmetrics and Google Analytics.

Feature Flag

GEOSPATIAL

Safety Assurance

Safety story

  • Local testing
  • Only attribute changes to HTML elements.

Automated test coverage

N/A

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@zandre-eng zandre-eng added product/feature-flag Change will only affect users who have a specific feature flag enabled product/invisible Change has no end-user visible impact labels May 8, 2024
@zandre-eng zandre-eng marked this pull request as ready for review May 8, 2024 12:41
@zandre-eng zandre-eng merged commit ff0aeff into master May 22, 2024
12 checks passed
@zandre-eng zandre-eng deleted the ze/geospatial-metrics branch May 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/feature-flag Change will only affect users who have a specific feature flag enabled product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants