Remove FormplayerPreviewSingleApp view #34569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This view is not referenced anywhere in code, either by name or urlname.
gherceg
requested review from
orangejenny,
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
dimagimon
added
the
Risk: Medium
Jtang-1
approved these changes
May 8, 2024
orangejenny
approved these changes
May 8, 2024
orangejenny
approved these changes
May 8, 2024
orangejenny
approved these changes
May 8, 2024
MartinRiese
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
I can't say for sure, but I think it is the case that this page has been broken since at the very least this change, since
_format_appassumedappwas app json, not an Application object, and callinggeton an Application object behaves very differently than on an app json obj. The point being, this view has likely not been working for nearly 4 years, and from what I can tell, is not referenced anywhere in HQ by view name or url name.Therefore, I'm removing it!
Feature Flag
Safety Assurance
Safety story
View is not accessible and up until very recently, has had a bug that leads to a 500 when attempting to access it by typing in the url endpoint.
Automated test coverage
QA Plan
No
Rollback instructions
Labels & Review