Migrate models to use OpportunityAccess as forieng key #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
commented
Jan 24, 2024
| ) | ||
| app = models.ForeignKey(CommCareApp, on_delete=models.PROTECT) | ||
| opportunity = models.ForeignKey(Opportunity, on_delete=models.PROTECT) | ||
| opportunity_access = models.ForeignKey(OpportunityAccess, on_delete=models.CASCADE, null=True) |
There was a problem hiding this comment.
Same as above.
pxwxnvermx
commented
Jan 24, 2024
| ) | ||
| module = models.ForeignKey(LearnModule, on_delete=models.PROTECT) | ||
| opportunity = models.ForeignKey(Opportunity, on_delete=models.PROTECT) | ||
| opportunity_access = models.ForeignKey(OpportunityAccess, on_delete=models.CASCADE, null=True) |
There was a problem hiding this comment.
Only this line was added and the model was moved to be below OpportunityAccess to avoid any undefined warnings.
pxwxnvermx
force-pushed
the
pkv/standardize-opportunity-access-use
branch
2 times, most recently
from
ec70316
to
33b91af
Compare
calellowitz
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
This is Part 1 of the Migration which creates the field and populates it. All the code related to refactoring the usage of Opportunity Access will be in a second PR to keep the diff small enough to review.