CommCare Connect #2696
Open
CommCare Connect #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting ready for network calls.
Initial registration workflow working. Implemented basic photos page and SMS verification.
Basic password manager implementation after ConnectID login.
Implemented local encrypted DB for data related to Connect.
Some cleanup after achieving POC functionality. Using secure storage for password manager functionality.
Several UI improvements, rewording.
A couple small bug fixes. Preparing for OIDC calls.
Moved ConnectID activities into a sub-namespace called connect.
Showing recovery phone number in UI when sending alt OTP.
Now encrypting DB passphrase using a Cipher, and storing the encrypted passphrase in the global DB. Added table to global DB for storing ConnectKeyRecords (changed DB version to 6). Min SDK Version moved back to 16 now that we aren't using newer helper classes (EncryptedFile, MasterKeys).
Not allowing password option when prompting for biometric unlock during registration. Fixed bug where ConnectID button on login page would appear after logging out of an app even if ConnectID user was not configured. Disabled auto-login to app after unlocking ConnectID.
…ing a broken test).
… user to proceed to OTP page.
…strings.txt to strings.xml. Re-enabled strict mode. Small improvements to EncryptionUtils for versions before Android M. Some other small changes based on PR review.
…ne number is available, for debugging.
Added code for encrypting DB in Android version before API 23. Fixed going to alt. phone verification after password fails three times. Added better consent wording, links, and checkbox.
Some bug fixes for QA tickets. Better error messaging on registration and phone verification pages.
Storing alt number in Connect DB. Not allowing user to change primary number to match alt number. Fixed bugs involving forgetting ConnectID user and saved app credentials.
Changed code to update primary phone ad main reg. info when user returns to those screens after initial creation. Improvements to recovering workflow after crash or backup to start.
… user click on sign up again
|
@damagatchi retest this please |
shubham1g5
requested changes
Sep 24, 2023
| if (readyApps.size() == 1 || presetAppRecord != null) { | ||
| if ((readyApps.size() == 1 && (!ConnectIdManager.isConnectIdIntroduced() || ConnectIdManager.isUnlocked())) | ||
| || presetAppRecord != null) { | ||
| setLoginInputsVisibility(true); |
There was a problem hiding this comment.
@OrangeAndGreen I just noticed this while working on some merge conflicts, But since this code also gets triggered when connect is not enabled, should not setLoginInputsVisibility(true); should be in the if later on with condition if (ConnectIdManager.isUnlocked()) { ?
…f the API version prevents the app from taking the user directly to enrollment, a message is displayed and a button allows the user to go to settings where they can enroll.
Improved biometric enrollment for Android versions before API 30
Rearranged UI for biometric configuration to save vertical space
…g registration (when there aren't any other options configured yet).
Fixed populating phone number input from existing phone number.
Not showing the "Other Options" button on the fingerprint unlock dialog when it is shown during ConnectID registration.
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@damagatchi retest this please. |
|
@damagatchi retest this please |
|
@damagatchi Retest this please |
1 similar comment
|
@damagatchi Retest this please |
…nto feature/connect
…nto feature/connect
Added JVM memory to fix OOM during build
|
@damagatchi Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feature branch for CommCare Connect work
Product Description
Adds functionality for CommCare Connect.
User can register/recover a ConnectID account from the app login page.
User can unlock ConnectID once account has been registered/recovered.
When CID is unlocked, user can login to apps automatically using passwords that are securely stored in the app.
Safety Assurance
Safety story
QA has a test plan for ConnectID functionality so far.