Initial development on Connect workflows #2695
Conversation
Configured project to use Android Navigation component. Created nav graph for Connect workflows. Created 5 of the Connect pages and built UIs (some work still to do).
…android into dv/connect_initial
…re-android into dv/connect_initial
Moved Connect Job classes to namespace where DB storage will be.
app/res/values/strings.xml
Outdated
| @@ -606,6 +606,35 @@ | |||
| <string name="connect_pictures_skip" cc:translatable="true">Skip</string> | |||
| <string name="connect_pictures_continue" cc:translatable="true">Continue</string> | |||
|
|
|||
| <string name="connect_title" cc:translatable="true">Connect</string> | |||
There was a problem hiding this comment.
Actually I think all connect strings should have cc:translatable not set. cc:translatable is meant for CC app's translations which are contained in the app ccz bundle and can be different for each apps. But Connect translations are independent of CC app and will be standard across different CC apps.
| View view = inflater.inflate(R.layout.fragment_connect_delivery_details, container, false); | ||
|
|
||
| TextView textView = view.findViewById(R.id.connect_delivery_title); | ||
| textView.setText(getString(R.string.connect_delivery_review_title)); |
There was a problem hiding this comment.
you can set static strings in the xml itself.
| public View onCreateView(LayoutInflater inflater, ViewGroup container, | ||
| Bundle savedInstanceState) { | ||
| ConnectJob job = ConnectJobIntroFragmentArgs.fromBundle(getArguments()).getJob(); | ||
| getActivity().setTitle(job.getTitle()); |
There was a problem hiding this comment.
can we use a Android view model to bind the UI here instead ? That will take care of things like restoring data state on configuration changes.
| return view; | ||
| } | ||
|
|
||
| private static class MyJobsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> { |
There was a problem hiding this comment.
This should probably be in a separate file as JobsAdapter which can be used both for all jobs and my jobs tabs.
Implemented UI element for circular progress bar. Implemented database storage and first API call. Changed all Connect strings to not specify translatable.
|
@OrangeAndGreen Wants to flag that this PR has taken the same course as earlier Connect PR and is becoming very big to manage. Not asking to change anything with the current PR but we must shift our approach on future connect work to do smaller PRs with smaller commits and try to close existing PRs proactively by requesting reviews on them and addressing feedback before taking on new work. As an example, This Android 13 PR demonstrates how to break changes in individual commits for them to be easily reviewed by commit. |
Added new drawables at all the resolutions.
…hanges Improve audio recording configuration
User shown a reminder tile on Connect Jobs and app home pages for a week after registration, prompting them to perform verification. After a week, user is forced to perform secondary phone verification in order to unlock ConnectId. Deleting all Connect DB data when user severs link to their ConnectId account. Added registration date to ConnectUserRecord
Showing Connect apps in front login page, user can login to them directly. Arrow button in jobs lists for jobs in progress now goes directly to learn/deliver app. Additional button now shown to take user to current job info page. Daily progress bar added to app home page when in delivery app (and job not finished yet). "View Job Status" button added to app home page for Connect apps.
… delivery progress).
Backing up/logging out from app home page always goes back to login screen, i.e. locks ConnectID.
…ready forgot their PIN by that point. Swapped Sync and Connect buttons on app home page (better visual alignment on UI).
|
@damagatchi Retest this please |
… Navigation workflow). Restored default nav host for ConnectActivity. Finishing ConnectActivity when launching learn/deliver app. Disabled buttons to launch learn/deliver app when viewing job info from inside an app.
…nto dv/nav_fixes
|
@damagatchi Retest this please |
Navigation fixes for Connect workflows
…re-android into dv/connect_initial
Increasing JVM memory to fix OOM during build
…re-android into dv/connect_initial
…er after several API calls.
…re-android into dv/connect_initial
|
@damagatchi Retest this please |
|
@damagatchi Retest this please |
…gs in to app. Restored app launch buttons by default in job info pages. Not clearing active job whenever jobs list shows.
…jump directly to learn/delivery progress. Deleted ConnectJobInfoActivity (no longer necessary).
Fixing single-activity with Navigation component and multiple entry points
Summary
Connect navigation flow
Added Android Navigation component (and SafeArgs plugin) to the project.
Implemented Connect navigation graph.
Implemented 5 UI screens as fragments and built/populated the UIs.
Product Description
When user unlocks ConnectID on login page, button saying "Go to Connect Menu" now appears.
When clicked, the user sees the Jobs List fragment, and can begin navigating through screens with mock data.
Safety Assurance
Automated test coverage
No tests yet