added test for Mobile Pins #2593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damagatchi retest this please |
|
@kbo001 Looks like this test is failing currently on BS |
shubham1g5
requested changes
Nov 1, 2022
| @BrowserstackTests | ||
| class MobilePinTests : BaseTest() { | ||
| companion object { | ||
| const val CCZ_NAME_1 = "basic_tests_latest.ccz" |
There was a problem hiding this comment.
can we name these varialbles for what they are like BASIC_TESTS_CCZ_NAME , BASIC_TESTS_APP_NAME and so on..
|
|
||
| @Before | ||
| fun setup() { | ||
| if (CommCareApplication.instance().currentApp == null) { |
There was a problem hiding this comment.
why not use installApp directly like other instrumentation tests ?
| onView(withText("Developer Options")) | ||
| .perform(click()) | ||
| InstrumentationUtility.openOptionsMenu() | ||
| onView(withText("Mobile Privileges")) |
There was a problem hiding this comment.
since this is not actually going to grant any priviliges, would not steps below fail to enable pin option ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added MobilePinTests.kt and 2 corresponding .ccz files that cover testcases in the Mobile Pins tab of the Mobile Test Plan:
https://docs.google.com/spreadsheets/d/1X9YAf_g1Cq9vZZdCkcBLnRSFrhZuk_vEyCSM3sD5QvM/edit#gid=1556040007
Feature Flag
Product Description
Safety Assurance
Automated test coverage
MobilePinTests.kt covers tests for:
Safety story
Executed in local AVD as well as physical device, ran successfully.