Add ktlint to improve linting of kotlin files #2543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saw this PR dimagi/commcare-core#1064 and thought it might be a good idea to add ktlint.
https://github.com/pinterest/ktlint is an amazing kotlin linter library which provides a built-in formatter so that we don't have to fix those issues manually(Although I had to fix some of the existing issues manually 馃槄 see 3rd commit).
PR uses https://github.com/pinterest/ktlint/#-with-gradle to add ktlint to the project.
After this change, the
danger-lint
pr tool should most probably be able to comment these lint issues on the PR(will have to test). Or maybe thelint
task would make the PR checks fail(also need to test this).Regardless, we now have 2 gradle tasks:
./gradlew ktlint
this returns all the lint issues in the kotlin files../gradlew ktlintFormat
will fix those lint issuesPS: We should consider upgrading kotlin version. Current is 1.3.72
Feature Flag
Product Description
Safety Assurance
Automated test coverage
Safety story