Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint error with custom CSS class #2300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

comatory
Copy link

@comatory comatory commented May 10, 2024

Relates to #2261 - this makes the linter pass all the checks. The issue is that "nextra" is some kind of indirect dependency for the website but two components are using nextra-scrollbar CSS class.

I fixed this by adding this class to whitelist of the tailwindcss/no-custom-classname eslint rule.

Description

I wanted to contribute to the project but was bothered that basic checks do not work. I decided to do this quick fix.

Fixes #2299

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

Run pnpm lint on your local machine, all checks should pass. These checks should now also pass in CI

Test Environment:

  • OS: macOS Sonoma 14.3.1
  • @graphql-eslint/...: "4.0.0-alpha.0"
  • NodeJS: 18.15.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

Maybe the lint rule is correct and we shouldn't use the custom class name. But depending on nextra seems indirect, searching for it only yields results in pnpm-lock.yaml. So to me, it even seems very suspicious, perhaps we could delete it?

Relates to dimaMachina#2261 - this makes the linter pass all the checks. The
issue is that "nextra" is some kind of indirect dependency for
the website but two components are using `nextra-scrollbar` CSS
class.

I fixed this by adding this class to whitelist of the
`tailwindcss/no-custom-classname` eslint rule.
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 503f4cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter does not pass checks
1 participant