Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rem size hack, closes #192 #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raikasdev
Copy link
Member

Removing the rem size hack as described in #192 and replacing it with a SASS function (from the article mentioned in the issue
).

The sizes might be wonky! The change from 1rem = 10px to rem function was made with VSCode replace using Regex, so errors are possible. No problems with building or stylelint, though.

Note: CSS variables must use the compile time syntax #{rem(16px)} for it to work. Using it straight in statements or in SCSS variables is fine.

Closes #192

@height
Copy link

height bot commented Sep 25, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@ronilaukkarinen
Copy link
Member

Hmm, I'm really not a fan of using a function or mixin for sizes that are everywhere... Rather than this could we just change the math here and let stylelint-rem-over-px to take care of the conversion? We could change the math and then, change/remove the root size for body and then just go through every font size and re-save the files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove root font-size 62.5%
2 participants