Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove root font-size 62.5% #192

Open
ronilaukkarinen opened this issue Aug 23, 2023 · 0 comments · May be fixed by #196
Open

Remove root font-size 62.5% #192

ronilaukkarinen opened this issue Aug 23, 2023 · 0 comments · May be fixed by #196
Assignees
@ronilaukkarinen

Comments

@ronilaukkarinen
Copy link
Member

A good point brought up by latenssi on wpfi Slack: Should we even have 62,5% nowadays? Article: Should I change the default HTML font-size to 62.5%?. Because we use it in :root rather than html, it's not a problem, but it's not needed any more because we have a stylelint plugin that converts the rems automatically.

We should perhaps revert back to the default soon.
@ronilaukkarinen ronilaukkarinen self-assigned this Sep 9, 2023
@raikasdev raikasdev linked a pull request Sep 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronilaukkarinen ronilaukkarinen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed rem size hack, closes #192 raikasdev/air-light
1 participant
@ronilaukkarinen