Added Broadcast ListIdentity support #13
Conversation
|
It probably could have been done in a simpler manner but I wanted to follow the netty style you used everywhere else. Technically this could also be used to get a ListIdentity from a unicast datagram also. There is no timeout. Specify a Consumer during instantiation. The consumer will be called for every ListIdentity received on that channel. |
|
It would also help if I referenced the correct issue. Original post edited to reference issue 12 not 11. |
|
Thanks, this looks good. I need to implement the WriteTagFragmented service soon and then I'll do a new release. |
| EnipPacket.encode(packet, buf); | ||
|
|
||
| channel.writeAndFlush(new DatagramPacket(buf, address)); | ||
| buf.release(); |
There was a problem hiding this comment.
Hmm. I intermittently get a refCount error here. Are there some conditions where new DatagramPacket() will or will not release() the buffer on its own?
There was a problem hiding this comment.
I think it's released when you write it to the channel. If you retained it at some point you'd have to also release it.
Issue #12