Databases: Set Kafka Connection Attributes (port, uri, private_uri) #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+617
to
+618
| // default for kafka will be Public SASL port, consistent with UI | ||
| d.Set("port", kafkaPublicSSLPort) |
There was a problem hiding this comment.
Are the ports guaranteed to be stable? Maybe we should grab it from the response? Something like:
const kafkaSASL = "sasl"
if database.Connection.ApplicationPorts != nil {
if saslPort, ok := database.Connection.ApplicationPorts[kafkaSASL]; ok {
d.Set("port", saslPort)
}
}| func buildKafkaConnectionURI(conn *godo.DatabaseConnection, port int) string { | ||
| host := conn.Host | ||
|
|
||
| uri := fmt.Sprintf("%s:%d", host, port) |
There was a problem hiding this comment.
Lets make sure that this is consistent with what the DBaaS team will eventually return from the API. Should there be a scheme? The other engines all seem to use the format scheme://user:pass@host:port
There was a problem hiding this comment.
Lets make sure that this is consistent with what the DBaaS team will eventually return from the API. Should there be a scheme? The other engines all seem to use the format
scheme://user:pass@host:port
Converting this PR to a draft as dbaas said they might actually get to it this week or next!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1121
Database team is working on a ticket to address this in the API layer, but in the meantime this sets the port, uri, and private uri at the terraform layer so users can easily collect connection details for their kafka clusters.
Default port will be the public SASL port, 25073. This is consistent with the UI.