Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add. Configuration subcommand to databases #1430

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Add. Configuration subcommand to databases #1430

merged 2 commits into from
Oct 10, 2023

Conversation

titanventura
Copy link
Contributor

Fixes #1354 partially

Please review @danaelhe

@titanventura
Add. Configuration subcommand to databases
0a8bdd9 
Signed-off-by: titanventura <aswath7862001@gmail.com>
@titanventura
Copy link
Contributor Author

Ping @danaelhe !

Thank you

danaelhe
danaelhe approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks AWESOME! Just tried it out and everything looks good on my end! Thank you for this great contribution 👍

@danaelhe danaelhe merged commit 58e920c into digitalocean:main Oct 10, 2023
6 checks passed
@danaelhe danaelhe mentioned this pull request Oct 10, 2023
Open
@titanventura
Copy link
Contributor Author

titanventura commented Oct 10, 2023 •
edited

Thanks @danaelhe . Please do add hacktoberfest-accepted to this if possible !

titanventura added a commit to titanventura/doctl that referenced this pull request Oct 28, 2023
@titanventura
commands: add update config subcommand to databases (digitalocean#1430)
1915f37 
Signed-off-by: titanventura <aswath7862001@gmail.com>
@titanventura titanventura mentioned this pull request Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow retrieving and updating database cluster configuration
2 participants
@titanventura @danaelhe