Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving and updating database cluster configuration #1354

Open
jnoordsij opened this issue Mar 6, 2023 · 6 comments · Fixed by #1430
Open

Allow retrieving and updating database cluster configuration #1354

jnoordsij opened this issue Mar 6, 2023 · 6 comments · Fixed by #1430
Labels
api-parity Feature supported in the DigitalOcean API not yet implemented in doctl hacktoberfest suggestion

Comments

@jnoordsij
Copy link

What is the problem this feature would solve? Please describe.

In the DO API docs, I found that it is possible to retrieve database cluster configuration and also to update it. However, using the API directly is somewhat cumbersome.

Describe the solution you'd like
It would be great to have a doctl to do this, e.g. doctl databases configuration get <database-id>. The output would probably be JSON, or maybe could be formatted with a flag. For setting the input should probably also be JSON?

@danaelhe danaelhe added the api-parity Feature supported in the DigitalOcean API not yet implemented in doctl label Mar 6, 2023
@aswath-s-tw
Copy link

Would like to pick this up. Please assign !

@aswath-s-tw
Copy link

Hi, I have a few queries

The godo.Client.DatabaseService has methods to get configuration for a particular engine ex. GetPostgreSQLConfig, GetRedisConfig, GetMySQLConfig, should we make our cli commands specific to an engine or call Get to know the EngineSlug and call the corresponding config method accrodingly ?

I think the same question applies of updating the config as well.

Thanks !

@aswath-s-tw
Copy link

aswath-s-tw commented Oct 4, 2023

Ping ! @danaelhe @jnoordsij

@danaelhe
Copy link
Member

danaelhe commented Oct 4, 2023

That's a great question! We're thinking to pass in an --engine flag as such:
doctl databases configuration get --engine postgress <db-id>

For update the config, to avoid having to pass in a lot of flags, it would be better to just accept JSON.

@aswath-s-tw
Copy link

aswath-s-tw commented Oct 7, 2023

Thought of raising separate PRs for each subcommand. Will be doing it from this account -> https://github.com/titanventura

@danaelhe
Copy link
Member

Partially solved in #1430 by adding implemmentation for doctl databases configuration get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-parity Feature supported in the DigitalOcean API not yet implemented in doctl hacktoberfest suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants