Allow redirect to external sites if CORS isn't enabled #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Jan 11, 2024
| // If the send method throws an exception, redirect to the form action URL. | ||
| // This can happen for example if redirecting to an external site, which doesn't have CORS enabled, | ||
| // so we can't use Ajax. | ||
| window.location.href = url; |
There was a problem hiding this comment.
This won't work for forms that are submitted via POST. I don't think this can be really fixed at all except by disabling the JS form submission in those forms
There was a problem hiding this comment.
Ok, I'll share my example code soon to show my use case
There was a problem hiding this comment.
Here's the example: amitaibu/ihp-landing-page#35
If you navigate to http://localhost:8000 without the PR it will result with console error. With the PR you'll be redirected to the repo of one of the best Haskell frameworks! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1889