fvirga/new query route #1538
Open
fvirga/new query route #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we error here should return too
francescov1
commented
Aug 31, 2023
| @@ -260,7 +260,7 @@ def determine_billable_directory_file_and_instance( | |||
|
|
|||
There was a problem hiding this comment.
See #1536 for comments about the diffs
| @@ -25,13 +25,6 @@ def __init__(self, session, project, member, directory = None): | |||
| self.session = session | |||
| self.member = member | |||
| self.directory = directory | |||
| # Additional security check just for sanity | |||
| Project_permissions.by_project_core( | |||
There was a problem hiding this comment.
This is a duplicate.
Context is that this is called later in SqlAlchemyQueryExecutor
Part of larger goal of aligning permissions into the same place
There was a problem hiding this comment.
Also that in general we are trying to put more validation at execution stage rather then prep/build stage (e.g dataset IDs which rely on the query string builder to format it first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1536 for relevant comments & context (same diff, just created on a fork instead of direct on repo)