Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added support for colors for the sketch extractor #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerradpatch
Copy link

Pull request for add sketch 69.2 support, and add some defaults when values are not provided in sketch.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


j0p035x seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zackbrown
Copy link
Member

Hey Jerrad, thanks for this! I'd love to merge this — two issues:

  1. Can you please sign the CLA?
  2. Travis isn't detecting this PR, which seems to be an issue on their end. I'm pursuing this with them. Once it's back up and running, we can verify that tests pass.

@roperzh
Copy link
Member

roperzh commented Dec 1, 2020

Chiming in, this looks great! thanks for the fix! to make the build pass you need to do two things:

  1. This project doesn't support the optional chaining operator (yet!) please use an alternative here:

    const alignment = mapNSTextAlignment(textStyle.NSParagraphStyle.style?.alignment || 0); //default value as of sketch v69.2

  2. Fix the lint errors, you can automatically fix most of them with yarn fix.

@roperzh roperzh linked an issue Dec 1, 2020 that may be closed by this pull request
@tomastrajan
Copy link

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diez extractor does not extract colors for sketch 69.2
5 participants