New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update Yoga to 3.0 #2711
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 862e2cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closes diegomura#2692 Closes diegomura#2507 This PR updates Yoga to 3.0. See the list of new features, improvements, and potential breaking changes in diegomura#2692.
@wojtekmaj this looks good. What's missing? |
@diegomura See the original ticket: we will be unable to provide CJS builds as Yoga 3 is a pure ESM module. |
Sorry! Missed that. Huh, good decision to make. Would be nice to push forward that and just embrace ESM but I'm afraid that would break a lot of setups. Will think about this. Any input would be welcomed! |
I think the question is more WHEN and not IF. It's really up to you: how much further are you able (and willing to!) push the v2 forward? If you think that significant improvements can still be made, you may want to hold off with v3 for a while, to avoid maintaining two releases at the same time. If you think v2 is "pretty much ready" and you're basically only maintaining it, then it would be best to bite the bullet and remove CJS builds. The move will also improve the experience for ESM users (see #2507), userbase of which is ever growing, at the expense of CJS users, userbase of which is ever shrinking. Please note that removing CJS builds does not stop CJS users from:
|
Closes #2692
Closes #2507
This PR updates Yoga to 3.0.
See the list of new features, improvements, and potential breaking changes in #2692.