Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo that breaks attempts of rendering non-visual elements like DEFS #2672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: typo that breaks attempts of rendering non-visual elements like DEFS #2672

wants to merge 1 commit into from

Conversation

somonek
Copy link

@somonek somonek commented Mar 12, 2024

Rendering content that contains <defs> fails because renderFns[node.type]; is undefined for nodeType DEFS, and the check is clearly wrong, since the renderFns is a declared object. Seems a typo.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 93d9e5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@somonek somonek changed the title Fix typo that breaks rendering of non-visual elements - ex: DEFS fix: typo that breaks rendering of non-visual elements like DEFS Mar 12, 2024
@somonek somonek changed the title fix: typo that breaks rendering of non-visual elements like DEFS fix: typo that breaks rendering non-visual elements like DEFS Mar 12, 2024
@somonek somonek changed the title fix: typo that breaks rendering non-visual elements like DEFS fix: typo that breaks attempts of rendering non-visual elements like DEFS Mar 12, 2024
wojtekmaj
wojtekmaj approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@wojtekmaj wojtekmaj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please run yarn changeset as explained in CONTRIBUTORS.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@somonek @wojtekmaj