Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of \xc2\xa9 copyright symbol #2645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattreid1
Copy link

The current specialCases in packages/layout/src/text/emoji.js only ignores the copyright symbol \xc2\xa9\xef\xb8\x8f and not the standard UTF-8 copyright symbol \xc2\xa9. The former has the VS-16 variation selector appended to the standard symbol, but the latter still appears to be treated as an emoji and doesn't render.

This PR simply adds the standard copyright symbol \xc2\xa9 to the specialCases array along with some comments explaining why there appears to be two copyright symbols.

Before the fix:
Before

After the fix:
After

Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: a41bf5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you please run yarn changeset as explained in CONTRIBUTORS.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants