Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpx转化快手小程序 #997

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mpx转化快手小程序 #997

wants to merge 2 commits into from

Conversation

lxjjjjjj
Copy link
Collaborator

@lxjjjjjj lxjjjjjj commented Apr 2, 2022

No description provided.

hiyuki
hiyuki reviewed Apr 2, 2022
View reviewed changes
packages/core/src/platform/builtInMixins/renderHelperMixin.js
@@ -3,7 +3,7 @@ import { isObject } from '../../helper/utils'
export default function renderHelperMixin () {
return {
methods: {
_i (val, handler) {
i (val, handler) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

快手不支持下划线开头的方法是吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的

hiyuki
hiyuki reviewed Apr 2, 2022
View reviewed changes
packages/webpack-plugin/lib/file-loader.js Outdated
@@ -31,7 +31,7 @@ module.exports = function loader (content, prevOptions) {
this._module.addPresentationalDependency(new RecordResourceMapDependency(resourcePath, 'staticResource', outputPath, packageRoot))
}

let publicPath = `__webpack_public_path__ + ${JSON.stringify(url)}`
let publicPath = options.mode === 'ks'&& queryObj?.currentName ==='app' ? JSON.stringify(url) :`__webpack_public_path__ + ${JSON.stringify(url)}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currentName哪来的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app中不能用绝对路径？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在file-loader中加的currentName 这个我可能没复制全 app中的路径用绝对路径解析不出来

hiyuki
hiyuki reviewed Apr 2, 2022
View reviewed changes
packages/webpack-plugin/lib/loader.js
@@ -250,7 +250,7 @@ module.exports = function (content) {
let ctor = 'App'
if (ctorType === 'page') {
// swan也默认使用Page构造器
if (mpx.forceUsePageCtor || mode === 'ali' || mode === 'swan') {
if (mpx.forceUsePageCtor || mode === 'ali' || mode === 'swan' || mode === 'ks') {
Copy link
Collaborator

@hiyuki hiyuki Apr 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

快手不支持component构造页面吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我再确认一下

@hiyuki
Copy link
Collaborator

hiyuki commented Apr 2, 2022

修复lint报错

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyuki hiyuki hiyuki left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lxjjjjjj @hiyuki