Feat react comp instance prop method #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/src/platform/patch/react/getDefaultOptions.js
# Conflicts: # packages/webpack-plugin/lib/template-compiler/compiler.js
hiyuki
reviewed
Apr 29, 2024
| detail: null, | ||
| ...rawEvent.nativeEvent | ||
| } | ||
| const eventObj = rawEvent.customEvent |
hiyuki
reviewed
Apr 29, 2024
| Object.keys(newData).forEach((key) => { | ||
| set(this, key, newData[key]) | ||
| }) | ||
| this.__mpxProxy.forceUpdate(callback) |
There was a problem hiding this comment.
mpxProxy.forceUpdate应该是for小程序的，rn下不应该调用
hiyuki
reviewed
Apr 30, 2024
| @@ -2535,7 +2537,11 @@ function postProcessComponentIs (el) { | |||
| }) | |||
| newChild.exps = el.exps | |||
| addChild(tempNode, newChild) | |||
| postProcessIf(newChild) | |||
# Conflicts: # packages/core/src/platform/patch/react/getDefaultOptions.js # packages/webpack-plugin/lib/template-compiler/compiler.js # packages/webpack-plugin/lib/template-compiler/gen-node-react.js
hiyuki
reviewed
May 15, 2024
| @@ -2426,6 +2426,7 @@ function processElement (el, root, options, meta) { | |||
| processStyleReact(el) | |||
| processEventReact(el, options, meta) | |||
| processAttrs(el, options) | |||
| processComponentIs(el, options) | |||
hiyuki
reviewed
May 15, 2024
| function createInstance ({ props, ref, type, rawOptions, currentInject, validProps, components }) { | ||
| const instance = Object.create({ | ||
| setData () { | ||
| setData (newData, callback) { |
There was a problem hiding this comment.
setData和wx保持一致，基于forceUpdate实现
hiyuki
reviewed
May 15, 2024
| @@ -47,6 +68,9 @@ function createInstance ({ props, ref, type, rawOptions, currentInject, validPro | |||
| return propsData | |||
| }, | |||
| __render () { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
跨端输出 react native 实例方法补充