fix flakiness in test com.dianping.cat.message.context.MessageIdFactoryTest#testDefaultDomainInParallel #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hofi1
force-pushed
the
bugfix/fix-flakiness-in-test
branch
from
ada9cb2
to
1f8c392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This test is flaky due to the fact that the time which is provided (to shut the pool down) can be sufficient or not. It can fail to shut the pool down in the provided time (what results in a failed test)
If the code remains the way it is, it results in a flaky test which sometimes passes and might fail other times (non-deterministic behavior).
Solution:
I added the condition if the shutdown is finished or if it failed. Furthermore, the duration for the shutdown got increased to make sure, that it is possible to finish the process without running in a timeout. If the shutdown reaches the timeout, the test fails as intended. If the shutdown is finished successfully, the same conditions (asserts) apply as before.
Result:
The test is deterministic and not flaky. This improves the quality of the test and reduces the time to search for the bug during future development.