fix: Fix native trigger environment #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarciabnz
approved these changes
May 15, 2024
| import org.hisp.dhis.rules.models.* | ||
| import org.hisp.dhis.rules.models.TriggerEnvironment.SERVER |
There was a problem hiding this comment.
These two imports are not used and could be removed
vgarciabnz
reviewed
May 15, 2024
| import org.hisp.dhis.rules.models.* | ||
| import org.hisp.dhis.rules.models.TriggerEnvironment.SERVER | ||
| import kotlin.jvm.JvmOverloads |
There was a problem hiding this comment.
Well, after a second thought, I do think we need to annotate the methods as overloaded if we want to make it optional in Java. In Kotlin, the last parameter would be optional, but in Java it will be mandatory unless the methods are mark as overloaded
There was a problem hiding this comment.
Unfortunately, @jvmoverloads is not allowed on interfaces and default parameters are not allowed on overriding methods.
So I am manually creating the overload methods.
Another option would be not to use an interface.
I am merging this so I can test the artifact but then we can discuss the best solution
Balcan
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate methods now have a
triggerEnvironmentparameter with a default value ofgetEnvironment().