Themes implementation #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I have made a change to the framework where the colors of different elements are defined as variables at the root level instead of being hard coded. This is to help with redefining these colors in order to get different themes for the site.
The idea is that a theme can be contained in its own class, where these definitions are overwritten. These changes are non-intrusive, everything looks as it did before if nothing overwrites these variables. No other css files needs to be included either, but I made a couple of example themes that I show in my Themes example. Feel free to look at it and say what you think.
I'm not sure if this is anything that you are actually intrested in adding into your project, but as I'm myself using this functionality I felt like I could at least make it a formal pull request.
Thanks in advance.