Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add traditional Chinesse version #66

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

johnnychhsu
Copy link

@johnnychhsu johnnychhsu commented Sep 7, 2020

#66

TODO list

  1. Translate first section

1. Translate first section
@johnnychhsu
Copy link
Author

@r06921039 please help to review, thanks

@r06921039
Copy link

@johnnychhsu My review is as follows:

line 5 : 網路上可以找到許多優質文章關於分散式系統的監控與設計
line 10: 寫程式的基本技巧
line 12: 如何寫出運行速度快的程式
line 14: 寫出運行速度極快的程式的進階技巧
line 18: 合理化
line 19: 精確化
line 20: 高風險化
line 25: 對程式進行優化是有代價的。一般來說,代價是程式變得更複雜更難懂 -- 優化過的程式基本上不會比原本的程式簡單。
line 27: 開發新的功能等等。 優化“固”然有趣,但不見得是該做的事。程式的運行速度當然重要,但確保程式的正確和可轉移等,這些事情也是不容忽視的部分。

@r06921039
Copy link

Oh I found out that I can add reviews on your commits!
I will do it next time XD.

@@ -0,0 +1,113 @@
# 優化你的Go程式

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建議中文跟英文之間都需要有空白,會比較好閱讀

請參考: https://github.com/sparanoid/chinese-copywriting-guidelines

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同意,謝謝你的建議跟分享!

3. "高風險化"

## 該在何時、何處開始優化
因為這很重要,所以我要~~說三次~~開門見山的說清楚:我們真的需要做優化這件事嗎?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

標題跟內文空一行

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

謝謝!

@dgryski
Copy link
Owner

dgryski commented Oct 26, 2020

This is ready to merge?

@johnnychhsu
Copy link
Author

not yet, still in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants