Allow Dgraph to run badger in memory #8877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil-goel
requested review from
akon-dey,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
dgraph-bot
added
area/core
mangalaman93
requested changes
Jun 17, 2023
dgraph/cmd/alpha/run.go
Outdated
| @@ -683,7 +681,7 @@ func run() { | |||
|
|
|||
| raft := z.NewSuperFlag(Alpha.Conf.GetString("raft")).MergeAndCheckDefault(worker.RaftDefaults) | |||
| x.WorkerConfig = x.WorkerOptions{ | |||
| TmpDir: Alpha.Conf.GetString("tmp"), | |||
| TmpDir: "./t", | |||
dgraph/cmd/alpha/run.go
Outdated
| @@ -700,7 +698,9 @@ func run() { | |||
| Badger: bopts, | |||
| } | |||
| x.WorkerConfig.Parse(Alpha.Conf) | |||
| fmt.Println("WORKER CONFIG ============", x.WorkerConfig) | |||
There was a problem hiding this comment.
will this print correctly? Could you copy an example here?
raftwal/log.go
Outdated
| @@ -114,7 +114,7 @@ func openLogFile(dir string, fid int64) (*logFile, error) { | |||
| Dir: dir, | |||
| EncryptionKey: encryptionKey, | |||
| EncryptionKeyRotationDuration: 10 * 24 * time.Hour, | |||
| InMemory: false, | |||
| InMemory: true, | |||
There was a problem hiding this comment.
we are doing this permanent?
worker/config.go
Outdated
| @@ -84,8 +84,6 @@ func (opt *Options) validate() { | |||
| x.Check(err) | |||
| td, err := filepath.Abs(x.WorkerConfig.TmpDir) | |||
| x.Check(err) | |||
| x.AssertTruef(pd != wd, | |||
There was a problem hiding this comment.
we should add a special condition for in memory.
worker/server_state.go
Outdated
| s.WALstore, err = raftwal.InitEncrypted(Config.WALDir, x.WorkerConfig.EncryptionKey) | ||
| x.Check(err) | ||
| } | ||
| { | ||
| // Postings directory | ||
| // All the writes to posting store should be synchronous. We use batched writers | ||
| // for posting lists, so the cost of sync writes is amortized. | ||
| x.Check(os.MkdirAll(Config.PostingDir, 0700)) | ||
| fmt.Println("Here", Config.PostingDir) |
harshil-goel
requested review from
sanjayk-github-dev,
all-seeing-code and
joshua-goldstein
as code owners
harshil-goel
commented
Jun 28, 2023
mangalaman93
requested changes
Jul 6, 2023
| @@ -118,19 +118,25 @@ func (s *ServerState) initStorage() { | |||
|
|
|||
| { | |||
| // Write Ahead Log directory | |||
| x.Checkf(os.MkdirAll(Config.WALDir, 0700), "Error while creating WAL dir.") | |||
| if Config.WALDir != "" { | |||
There was a problem hiding this comment.
@harshil-goel just trying to understand the changes.
Is it the case that when badger is run in-memory, WALDir and PostingDir will be empty? And raftwal.InitEncrypted() handles this case properly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.