Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reading routine with potential buffer overflow #1464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aradi
Copy link
Member

@aradi aradi commented May 16, 2024

Code produced by the NAG compiler was crashing at this point

Code produced by the NAG compiler was crashing at this point
Copy link
Member

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct, but not sure if there is anything weird about the parameter files.

src/dftbp/solvation/gbsafile.F90 Outdated Show resolved Hide resolved
src/dftbp/solvation/gbsafile.F90 Outdated Show resolved Hide resolved
src/dftbp/solvation/gbsafile.F90 Outdated Show resolved Hide resolved
@aradi
Copy link
Member Author

aradi commented May 17, 2024

Should be fine now. Changed error message and eliminated all superfluous code path in nextLine()

Copy link
Member

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating and possibly squashing, could you add a comment in the commit log to the effect that the nexline routine now only reads from a named file, as was never called with a unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants