Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE] add logo rendering #13986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[SITE] add logo rendering #13986

wants to merge 3 commits into from

Conversation

toshywoshy
Copy link
Contributor

Add logo rendering

  • use logo.png to generate logo.webp on listing page
  • use logo.png to generate logo.webp on welcome page

This adds the asset folder for hugo rendering and requires hugo-extended
To avoid any breakage, the old style remains supported and this adds rendering if the file exists

@toshywoshy toshywoshy requested a review from a team as a code owner April 22, 2024 17:10
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 02bfafc
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/6626c13d41154700087657c5
😎 Deploy Preview https://deploy-preview-13986--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattstratton
Copy link
Member

We will need to update documentation on the new Hugo version needed and ensure all scripts that load Hugo in various containers are also updated and tested.

* use logo.png to generate logo.webp on listing page
* use logo.png to generate logo.webp on welcome page

__This adds the asset folder for hugo rendering and requires
hugo-extended__
To avoid any breakage, the old style remains supported
and this adds rendering if the file exists

Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
@toshywoshy toshywoshy requested a review from a team as a code owner April 22, 2024 19:39
Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
@toshywoshy toshywoshy requested a review from a team as a code owner April 22, 2024 19:57
@toshywoshy
Copy link
Contributor Author

OK, added the new logo option to the documentation
The version of hugo defined in the workflow 0.123.3 is sufficient
All scripts are working now and all containers have been updated

toshywoshy added a commit to toshywoshy/devopsdays-web that referenced this pull request May 19, 2024
- add logo to overview page
- add logo to welcome page
- add logo to asset for devopsdays#13986

Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
@toshywoshy
Copy link
Contributor Author

I tested this now several times, it doesn't break old, and only provides an new option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants