Local Pool (manager) with Remote Workers + Configurable Worker collection #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervisor as poolboy_sup
… init/3 so that state record can be initialized without the 'undefined' default
…nstance, to avoid the need for type-checking, split-out multi-line funs from macro
…ker to the Worker-process
|
There's a lot of changes here and I'm not sure when I'll have time to review this :/ I will try to find some time though. |
|
Hi @Vagabond, you are right this has become a mess. Sorry about that. I would be happy to rework these changes into manageable chunks (PRs). Please let me know if that would actually work for you ;) |
* Add ets (ordered_set) to collection types * Implement strategies via out/1 of collection-types * Use only add/2 instead of prep/2 and app/2 * Run tests with all available strategies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should really be 2 as the title suggest. However, it was easier for me the to create it as single one. - Apologies! - I just wanted to get your thoughts on the changes first and find out whether you see these extensions useful. - I'm happy to take this further, e.g.: split the PR, etc.
Remote Workers
I use
poolboyat work and needed to create a pool of processes similar to therpcmodule implementation in Erlang/OTP. -rpc(orrex) is a single process, I needed a pool of them. - This led me to extendpoolboy, so that (local) workers could be started by a supervisor on a remote node.Worker Collection
In situations, where the worker is non-blocking, the pool performs better if the
checkout,checkinmechanism is not used. However, it's still a good idea to distribute the work-load between workers, e.g.: simply relying on random distribution. - This led me to considerrandom-accessdata-structures, likearrayandtuplefor the collection of workers. - I've added a module:poolboy_collectionthat encapsulates the data-structure, in which the workers are stored.