Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: filamentphp (original) #2122

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

AnshSinghSonkhia
Copy link

@AnshSinghSonkhia AnshSinghSonkhia commented Jan 29, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2120

Link to prove your SVG is correct and up-to-date.

https://filamentphp.com/

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, here are few changes that are needed:

  • Instead of plain-wordmark call the SVG original as the icon you added is the original filamentphp logo.
  • Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.
  • Because there is only 1 path and fill color you can use the filamentphp-original.svg as the base and make aliases for original-wordmark, plain, and plain-wordmark.

@AnshSinghSonkhia AnshSinghSonkhia changed the title new icon: filamentphp (plain-wordmark) new icon: filamentphp (original) Mar 8, 2024
using InkScape, SVGOMG, SVGviewer
@AnshSinghSonkhia
Copy link
Author

  • Instead of plain-wordmark call the SVG original as the icon you added is the original filamentphp logo.
  • Optimize and clean up the SVG like we did in the remix pr. Because the SVG only has 1 color, you can combine the paths into 1 path; This reduces the size of the svg and makes it possible for us the svg as an base/ alias for other version.

These changes are done!!

@AnshSinghSonkhia
Copy link
Author

  • Because there is only 1 path and fill color you can use the filamentphp-original.svg as the base and make aliases for original-wordmark, plain, and plain-wordmark.

Made some changes in devicon.json

"aliases": [
            {
                "base": "original",
                "alias": [
                    "original-wordmark",
                    "plain",
                    "plain-wordmark"
                ]
            }
        ]

Kindly. verify it @canaleal

devicon.json Show resolved Hide resolved
@canaleal
Copy link
Contributor

canaleal commented Mar 8, 2024

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

Removed:

fill="currentColor",
class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none"
@AnshSinghSonkhia
Copy link
Author

By the way, the SVG has a fill="currentColor" and class="transition duration-300 will-change-transform group-hover/filament:-translate-x-[1.2rem] motion-reduce:transition-none" that can be removed.

Done, anymore changes required?

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 🦖

I added any empty altnames array to the json and updated the svg paths a little so there are no line artifacts in icomoon

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants