Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint name to batch list #147

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LanesGood
Copy link
Member

This PR adds the checkpoint name for each batch to the batch list in the project page for greater distinction between batch exports. Without this, I am unable to distinguish between batches created for the same AOI using the same mosaic even if they are from different checkpoints.

The Batch endpoint doesn't return checkpoints, so I'm using the api client to fetch the name - this happens after row render.

@LanesGood LanesGood requested a review from vgeorge March 11, 2024 16:41
@LanesGood LanesGood marked this pull request as ready for review March 11, 2024 16:41
Copy link
Member

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LanesGood while this is working, I suggest we fix this by changing the batch API endpoint to include the checkpoint in the list. The frontend approach will trigger many unnecessary additional requests to the API.

@LanesGood
Copy link
Member Author

@vgeorge makes sense - I will flag as a potential enhancement for the backend and revert this to checkpoint id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants