Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Element.tagName and Node.ownerDocument #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanhoff
Copy link

This PR implements the following APIs:

It will allow the following code to operate correctly:

import React from 'react';
import ReactDOM from 'react-dom';
import undom from 'undom';

// The render function utilizes global variables so you will need this 
// if running it inside Node.js
// globals.window = {HTMLIFrameElement: function() {}}

ReactDOM.render(<p>Hello React!</p>, undom().document.body);

Sidenote

The best scenario would be adding get ownerDocument to Node instead of monkey patching Element at runtime, but currently that's impossible since Node is isolated from the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant