Further improve performance of Document creation. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up the create test by about **25-30%** by avoiding the call to `util.assign()` in the `createDocument()` function. Instead of that `Document#document` is now an accessor on the prototype, `defaultView` is an instance of a new `DefaultView` class, whose instances have links to the `document`, and finally the interesting constructors that are exposed via `Document` instances are all installed on the `Document` and `DefaultView` prototypes instead of the instances.
marvinhagemeister
approved these changes
Mar 30, 2019
andrewiggins
added a commit
to andrewiggins/undom
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the create test by about 25-30% by avoiding the call
to
util.assign()in thecreateDocument()function. Instead of thatDocument#documentis now an accessor on the prototype,defaultViewis an instance of a new
DefaultViewclass, whose instances have linksto the
document, and finally the interesting constructors that areexposed via
Documentinstances are all installed on theDocumentandDefaultViewprototypes instead of the instances.