[Proposal] Restrict etc/cron* to root user only, add Password policies #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedShaheen-MEC
changed the title
|
Hi @AhmedShaheen-MEC thanks for this contribution! Can you add a bit more explaination, why you want to restrict the directories? Also the change to the Password policies seems redundant, since we already have defaults present. |
schurzi
reviewed
May 10, 2024
Comment on lines
+34
to
+35
| os_auth_pw_max_age: 60 | ||
| os_auth_pw_min_age: 7 |
There was a problem hiding this comment.
these are already in the general defaults (https://github.com/dev-sec/ansible-collection-hardening/blob/master/roles/os_hardening/defaults/main.yml#L5-L6) so no need to declare them for every OS separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.