Fix Travis mime-types dependency #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis throws a gem install error about mime-types requiring Ruby 2.0, unless we pre install a version that still supports Ruby 1.9.
|
Ahhh, geez, that didn't fail when I ran it on my fork: https://travis-ci.org/gerrywastaken/wbench/builds/128272785 However I also fixed this issue recently, so I'll add another commit to this PR to (hopefully) address this failure too. |
Before this fix Travis reports the following error during the gem
install stage.
NoMethodError: undefined method `spec' for nil:NilClass
Fix found here:
travis-ci/travis-ci#5239 (comment)
gerrywastaken
force-pushed
the
fix-travis-mime-type-issue
branch
from
775a6a4
to
e9416ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis throws a gem install error about mime-types requiring Ruby
2.0, unless we pre install a version that still supports Ruby 1.9.
Hullo
By chance I was fixing this on another project and noticed you guys had pretty much the same issue. I attempted doing a pre-install using a .travis.yml, as other have suggested. However that didn't work. I tested running
bundle installagainst Ruby 1.9.3p551 on my machine and did not encounter this error, so this work around is only in place for Travis.Report by another user that the issue is still around despite being closed:
travis-ci/travis-ci#5145 (comment)
As a test I rebased #39 (which is waiting on this CI fix) and all came up green: https://travis-ci.org/gerrywastaken/wbench/builds/128276308