Announce accessibility settings #18460
Conversation
tidy-dev
force-pushed
the
announce-accessibility-settings
branch
from
355e251
to
0d39aad
Compare
| // When zooming, give the banner more space to display. | ||
| @media (max-width: 960px) { | ||
| height: auto; | ||
| padding-top: var(--spacing-half); | ||
| padding-bottom: var(--spacing-half); |
There was a problem hiding this comment.
I noticed that when I first tried to make message which was really long, the banner didn't handle text wrapping very well so I figured that meant zooming didn't wrap. This css just makes it so that when zoomed, there is not a height constraint so the banner will always be tall enough for the text. A concern would be if the banner got so tall it caused content below to be not visible, but this shouldn't happen as with the 30px in non-zoomed mode we are limiting the banner content to a one liner which wraps to three in the worst case.
Before:
After:
| import { LinkButton } from '../lib/link-button' | ||
| import { setBoolean } from '../../lib/local-storage' | ||
|
|
||
| export const accessibilityBannerDismissed = 'accessibility-banner-dismissed' |
There was a problem hiding this comment.
Should we make this accessibilityBannerShown instead and automatically set it once we show it the first time? In other words should we require that the user explicitly dismiss the banner or are we fine with having shown it to them once?
There was a problem hiding this comment.
user explicitly dismiss the banner
My thinking was explicitly dismiss it so that users don't miss it. Because if a user has no changes when they first open Desktop, they may not realize the implication of the settings on their day to day until they get into making some changes.
Other notes.. similar pattern we followed for the announcement about cherry-picking/re-ordering/squashing, the user had to dismiss to not see it again.
xref: https://github.com/github/desktop/issues/821
Description
This PR adds a banner to announce the new accessibility settings. It's purpose is to inform users of the settings especially those users who would find them more of a hinderance than a help and would desire to turn them off.
Screenshots
Release notes
Notes: [Improved] Add banner to announce the accessibility settings.