Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "View in Browser" to replace "View on GitHub" if the repository is not hosted on GitHub #17867

Draft
wants to merge 12 commits into
base: development
Choose a base branch
from
Draft

Add "View in Browser" to replace "View on GitHub" if the repository is not hosted on GitHub #17867

wants to merge 12 commits into from

Conversation

novialriptide
Copy link
Contributor

Closes #17846

Description

Changes the menubar and repository context menu

Screenshots

GitHub

Screenshot 2023-12-13 at 5 31 19 AM Screenshot 2023-12-13 at 5 31 50 AM Screenshot 2023-12-13 at 5 32 28 AM

GitLab (other)

Screenshot 2023-12-13 at 5 31 25 AM Screenshot 2023-12-13 at 5 31 45 AM Screenshot 2023-12-13 at 5 32 18 AM

Release notes

Notes:

Yippee

@novialriptide novialriptide changed the title Add "Open in your browser" to replace "Open on GitHub" Add "Open in your browser" to replace "Open on GitHub" if the repository is not hosted on GitHub Dec 13, 2023
@novialriptide novialriptide marked this pull request as draft December 13, 2023 16:52
@novialriptide novialriptide marked this pull request as ready for review December 13, 2023 16:59
@novialriptide novialriptide marked this pull request as draft December 13, 2023 18:27
@nchithanh00
Copy link

nchithanh00 commented Dec 21, 2023 •
edited

I think the title is not matched with the changes. It should be Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub
And why don't we replace the "View on GitHub" completely with "View in your browser"?

@novialriptide novialriptide changed the title Add "Open in your browser" to replace "Open on GitHub" if the repository is not hosted on GitHub Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub Dec 21, 2023
@novialriptide
Copy link
Contributor Author

novialriptide commented Dec 21, 2023 •
edited

I think the title is not matched with the changes. It should be Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub

Thanks

EDIT: In the PR it's now "View in Browser"

And why don't we replace the "View on GitHub" completely with "View in your browser"?

I've just left the decision to the GitHub staff. (I am just an outside contributor)

@novialriptide novialriptide changed the title Add "View in your browser" to replace "View on GitHub" if the repository is not hosted on GitHub Add "View in Browser" to replace "View on GitHub" if the repository is not hosted on GitHub Dec 22, 2023
@ProfetaXXIV ProfetaXXIV mentioned this pull request Jan 18, 2024
Open
LLotme
LLotme reviewed May 12, 2024
View reviewed changes
Copy link

@LLotme LLotme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLotme LLotme LLotme left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Open in Browser" to Repository menu to view GitLab (or other) repository online
3 participants
@novialriptide @nchithanh00 @LLotme